Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global path require & add vim swap files to gitignore #332

Merged
merged 2 commits into from
Mar 11, 2018

Conversation

dylanonelson
Copy link
Contributor

What kind of change does this PR introduce?
One code tweak and a change to the .gitignore file.

Did you add tests for your changes?
No.

If relevant, did you update the documentation?
n/a

Summary
Addresses a final piece of pr feedback from #265 and adds vim files to the gitignore.

Does this PR introduce a breaking change?
No.

Other information
n/a

@dylanonelson dylanonelson force-pushed the fix-global-path-require branch from abc6a8d to 3448fb5 Compare March 10, 2018 22:54
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@evenstensberg
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants