Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for document breaks live reload in web worker #308

Closed
matthewdenobrega opened this issue Nov 3, 2015 · 1 comment
Closed

Check for document breaks live reload in web worker #308

matthewdenobrega opened this issue Nov 3, 2015 · 1 comment

Comments

@matthewdenobrega
Copy link

Line 4 of client/index.js presumes the existence of document, which is not the case in a web worker (which also obviously doesn't have script tags). There should be an additional check here for whether document exists before querying the DOM for script tags.
@matthewdenobrega matthewdenobrega mentioned this issue Nov 3, 2015
Closed
@SpaceK33z
Copy link
Member

See #309 for why it's closed. Also note that PR #298 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpaceK33z @matthewdenobrega