Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put in existence check for document so live reload will work in webworker #309

Closed
wants to merge 1 commit into from

Conversation

matthewdenobrega
Copy link

This is a fix for #308

@PatrickJS
Copy link
Member

👍 I need this too

@jteplitz
Copy link

jteplitz commented Nov 4, 2015

👍 Also running up against this issue

@ocombe
Copy link

ocombe commented Nov 10, 2015

👍
Easy fix, could you merge this please, it would help for unusual environments such as webworkers :)

@PatrickJS
Copy link
Member

can you rebase

@matthewdenobrega
Copy link
Author

#298 is a fix for the same thing and includes an extra check - unless there's an issue with the extra check I'd suggest #298 gets used for this.

@jFensch
Copy link

jFensch commented Jun 21, 2016

Any progress on this? Would be awesome to get working with Angular2 supporting web workers.

@TheLarkInn
Copy link
Member

@matthewdenobrega could you please check and see if you can resolve conflicts on your side first?

@sokra
Copy link
Member

sokra commented Jun 29, 2016

No longer needed, because webpack-dev-server/client accepts a query string which contains the hostname.

webpack-dev-server/client?http://url-to-webpack-dev-server:port/

This will omit the access to document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants