following #106, makes options.publicPath required via the API. alphabetizes optionsSchema #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## beta #1055 +/- ##
======================================
Coverage ? 73.6%
======================================
Files ? 5
Lines ? 447
Branches ? 141
======================================
Hits ? 329
Misses ? 118
Partials ? 0Continue to review full report at Codecov.
|
|
Considering waiting on this one until 3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
BREAKING CHANGE Consistency update following comments on #106.
Did you add or update the
examples/?No need
Summary
#106 outlines a discrepancy of expectations in using the module API directly versus the CLI with regard to
publicPath. This changes the options schema to makepublicPatha required option and will fail gracefully if the option is not provided.This PR also reorganizes the optionsSchema.json file to alphabetize the
propertiesproperty and put more relevant meta at the beginning of the file.Does this PR introduce a breaking change?
YES Users previously not specifying a
publicPathin API options will now have to - though I'm not sure if works without doing so to begin with.Other information
This will likely need to release in a major version update as it may hose some implementations.