Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contribution): add CLA section #1963

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

yoshinorin
Copy link
Contributor

@yoshinorin yoshinorin commented Jun 4, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

Motivation / Use-Case

Current contribution guide does not exist about CLA. IMHO It is better to have CLA for a contributor.

I wrote it referencing webpack-cli.

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1963   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          28       28           
  Lines        1075     1075           
  Branches      321      321           
=======================================
  Hits          995      995           
  Misses         76       76           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27eb99c...9c88d72. Read the comment docs.

@hiroppy hiroppy merged commit 84955f8 into webpack:master Jun 17, 2019
@hiroppy
Copy link
Member

hiroppy commented Jun 17, 2019

Thanks

@yoshinorin yoshinorin deleted the add-cla-section branch June 17, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants