chore(deps): update husky and lint-staged #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.prettierignore
Outdated
| @@ -4,3 +4,4 @@ coverage | |||
| client-src/live/web_modules/ | |||
| node_modules | |||
| CHANGELOG.md | |||
| package-lock.json | |||
There was a problem hiding this comment.
We can remove this from here, because prettier doesn't change format of package-lock.json
There was a problem hiding this comment.
We can remove this from here, because prettier doesn't change format of package-lock.json
I agree.
wizardofhogwarts
suggested changes
Jul 16, 2019
.prettierignore
Outdated
| @@ -4,3 +4,4 @@ coverage | |||
| client-src/live/web_modules/ | |||
| node_modules | |||
| CHANGELOG.md | |||
| package-lock.json | |||
There was a problem hiding this comment.
We can remove this from here, because prettier doesn't change format of package-lock.json
I agree.
hiroppy
force-pushed
the
feature/update-lint-staged-and-husky
branch
from
36111eb to
0f970ae
Compare
hiroppy
force-pushed
the
feature/update-lint-staged-and-husky
branch
from
7ad4478 to
47bd6f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 32 32
Lines 1267 1267
Branches 357 357
=======================================
Hits 1173 1173
Misses 87 87
Partials 7 7Continue to review full report at Codecov.
|
|
@evilebottnawi PTAL |
alexander-akait
approved these changes
Jul 17, 2019
knagaitsev
pushed a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
Wait for #2123.
closes: #2085
closes: #2087
Breaking Changes
no
Additional Info