test(server): increase port mapping base number #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 33 33
Lines 1265 1265
Branches 361 361
=======================================
Hits 1171 1171
Misses 87 87
Partials 7 7Continue to review full report at Codecov.
|
hiroppy
reviewed
Jul 24, 2019
| @@ -46,7 +46,7 @@ const portsList = { | |||
| Iframe: 1, | |||
| }; | |||
|
|
|||
| let startPort = 8079; | |||
| let startPort = 8089; | |||
There was a problem hiding this comment.
Why did you change this? I thought it was only necessary to change the number of cli from 2 to 10.
There was a problem hiding this comment.
@hiroppy There are other tests that use the default ports near 8080, such as: https://github.com/webpack/webpack-dev-server/blob/master/test/server/utils/findPort.test.js. So I think we should provide some extra room to make sure those ports are available.
hiroppy
approved these changes
Jul 24, 2019
alexander-akait
approved these changes
Jul 24, 2019
wizardofhogwarts
approved these changes
Jul 27, 2019
knagaitsev
added a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
As mentioned in #2143, if we need to test CLI default port selection, which will use ports 8080, 8081, 8082... we should make sure the hard port mapping does not use these ports near port 8080. We just need to provide enough room for this default port assignment so that there will never be collisions.
Breaking Changes
None
Additional Info