Don't reload app upon proxy errors. #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the clientside application would reload whenever a proxy answered with an error reponse or in other ways behaved badly. This change removes that reloading behavior, as reload the clientside application probably won't fix any issue the proxy has anyway.
|
👍 seems fine to me. |
|
Thanks |
|
Any idea on when this might be released? It's a quite annoying. |
|
@rthewhite, this was released as part of |
This was referenced Sep 3, 2016
|
@SpaceK33z thank you for the heads up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the clientside application would reload whenever a proxy answered with an error response
or in other ways behaved badly. This change removes that reloading behavior, as reloading the clientside
application probably won't fix any issue the proxy has anyway.
/ping @SpaceK33z as he made these socket handlers in the first place
Refs #446