-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module API #1209
Module API #1209
Conversation
@simon04 @bebraw this is still a first draft, but I'm interested in your thoughts on the structure which I changed a bit from the original page in the old docs. I think it will read better this way as most things are now grouped by style usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Not a lot to go till it can be merged.
Took the content from https://webpack.github.io/docs/api-in-modules.html and started re-organizing it. This is still a work in progress.
content/api/module.md
Outdated
|
||
|
||
|
||
## Webpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to split here and push webpack specifics to another article? It's quite long otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe it would make more sense to split at the ## Module Variables
section? Until we have that a nicer page grouping (#438) maybe something like module-api-methods.md
and module-api-variables.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk I guess it could work to split out webpack specific functionality sections separate, I just think it may be odd having to jump around the two articles to see all module variables (methods would probably be ok as people would most likely choose one method and stick with it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables is a good split, yeah.
Port module api page from old docs.
Took the content from https://webpack.github.io/docs/api-in-modules.html and
started re-organizing it. This is still a work in progress.
Fixes #1099 and adds a significant bit of missing documentation.