Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dev-server): Add documentation for serveIndex option #2953

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

EslamHiko
Copy link
Member

add documentation for serveIndex option in this PR

webpack/webpack-dev-server#1752

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but default goes into type section, also suggesting a rephrase

src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
@EslamHiko
Copy link
Member Author

@EugeneHlushko some checks are failed, can I do something about them?

@EugeneHlushko
Copy link
Member

We are testing netlify deploy for previewing PRs, no need to do anything

@EugeneHlushko EugeneHlushko merged commit 00e6773 into webpack:master Apr 19, 2019
@EugeneHlushko
Copy link
Member

Thanks!

@EugeneHlushko
Copy link
Member

in case anyone interested, here is our first preview: https://5cba05c10f05471a05b57258--webpackjsorg-pr-previews.netlify.com/

@EslamHiko
Copy link
Member Author

@EugeneHlushko You're Welcome 😄

@EslamHiko EslamHiko deleted the serve-index-documentation branch April 19, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants