Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve require docs #6235

Merged
merged 1 commit into from
Jun 28, 2022
Merged

improve require docs #6235

merged 1 commit into from
Jun 28, 2022

Conversation

vankop
Copy link
Member

@vankop vankop commented Jun 22, 2022

  • describe critical dependency warning

there was a section about critical dependency in archived docs about warning like:

Critical dependencies:
158:18-25 require function is used in a way in which dependencies cannot be statically extracted

will be great to add this in current docs too. not sure where place this better...

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 11:07AM (UTC)

@chenxsan
Copy link
Member

Seems to be require.context related, so maybe put it under https://webpack.js.org/api/module-methods/#requirecontext

@vankop
Copy link
Member Author

vankop commented Jun 23, 2022

title is misleading since this warning related to all require functions

@chenxsan
Copy link
Member

Then maybe try https://webpack.js.org/api/module-methods/#commonjs section if it's require specific?

@vankop
Copy link
Member Author

vankop commented Jun 27, 2022

technically this is part of commonjs section maybe we need a subtitle for this?

@chenxsan
Copy link
Member

technically this is part of commonjs section maybe we need a subtitle for this?

I think a warning should be good, another subtitle might not fit well in this case when there're all module methods:

CleanShot 2022-06-27 at 18 28 45@2x

- describe critical dependency warning
@vankop vankop force-pushed the critical-dep-warning branch from 7b815ef to 24bd075 Compare June 27, 2022 11:04
@vankop
Copy link
Member Author

vankop commented Jun 27, 2022

I have added title

@chenxsan chenxsan merged commit 089cfa2 into webpack:master Jun 28, 2022
@vankop vankop deleted the critical-dep-warning branch June 28, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants