Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Migration): loadersuse #6373

Merged
merged 2 commits into from
Oct 19, 2022
Merged

docs(Migration): loadersuse #6373

merged 2 commits into from
Oct 19, 2022

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Sep 5, 2022

My understanding is that the deprecated loaders was removed in webpack/webpack#9138 which was in https://github.com/webpack/webpack/releases/tag/v5.74.0 (should that have been a major version upgrade?)

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.

My understanding is that the deprecated `loaders` was removed in webpack/webpack#9138 which was in https://github.com/webpack/webpack/releases/tag/v5.74.0 (should that have been a major version upgrade?)
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: julienw / name: Julien Wajsberg (30db685)

@vercel
Copy link

vercel bot commented Sep 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webpack-js-org ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 1:16PM (UTC)

@chenxsan
Copy link
Member

chenxsan commented Oct 8, 2022

@julienw Do u think you can sign the CLA?

@julienw
Copy link
Contributor Author

julienw commented Oct 14, 2022

I just asked again to the person in charge in my company. Stay tuned...

@julienw
Copy link
Contributor Author

julienw commented Oct 19, 2022

done!

src/content/migrate/5.mdx Outdated Show resolved Hide resolved
Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@chenxsan chenxsan merged commit 399a3c6 into webpack:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants