Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test setup and bring back chai as a dependency #1147

Merged
merged 2 commits into from
Mar 24, 2024
Merged

update test setup and bring back chai as a dependency #1147

merged 2 commits into from
Mar 24, 2024

Conversation

fippo
Copy link
Member

@fippo fippo commented Mar 24, 2024

using [email protected] which is an older version that still works with karma-chai

fippo and others added 2 commits March 24, 2024 12:13
@fippo
Copy link
Member Author

fippo commented Mar 24, 2024

@jan-ivar @Pehrsons it seems FF Nightly rejects modifications to RTCSessionDescription.sdp.
This has been tried in Chromium before and had to be pulled out. The test fix here is trivial but you may want to communicate this better than "we added a console warning" (which does not even have a bugzilla link)

https://webrtchacks.github.io/chromestatus/?buckets=1676,3451 shows data. This is ~1/3 of setRemoteDescription

@fippo fippo merged commit 5f90e25 into main Mar 24, 2024
5 checks passed
@fippo fippo deleted the fix-chai branch March 24, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant