Concatenate small buffers #2163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
concatenate/small-buffers
branch
from
eab2d05
to
50bfb1a
Compare
Make `Sender.frame()` always return a single buffer if the payload length is less than 126 bytes. This is done by copying the data but for small buffers it is more efficient than using `socket._writev()`.
lpinca
force-pushed
the
concatenate/small-buffers
branch
from
50bfb1a
to
881fbb6
Compare
|
As expected, the speedup decreases as the number of clients grow, so I am not sure if it is worth it. |
streetracer48
approved these changes
Nov 13, 2023
lortmorris
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
Sender.frame()always return a single buffer if the payload length is less than 126 bytes. This is done by copying the data but for small buffers it is more efficient than usingsocket._writev().