Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alternate fullscreen shortcut ⌘+Shift+F #26

Closed
feross opened this issue Mar 5, 2016 · 0 comments
Closed

Add alternate fullscreen shortcut ⌘+Shift+F #26

feross opened this issue Mar 5, 2016 · 0 comments

Comments

@feross
Copy link
Member

feross commented Mar 5, 2016

⌘+Shift+F is an alternate to ⌘+Control+F to fullscreen some apps on Mac. Chrome supports it.

The standard on Mac is ⌘+Control+F. That's already supported and should continue to show up as the shortcut in the View menu.

screen shot 2016-03-05 at 3 20 38 pm
feross added a commit that referenced this issue Mar 6, 2016
@feross
Add alternate fullscreen shortcut ⌘+Shift+F (fix #26)
f6c9750 
Uses https://npmjs.com/package/electron-localshortcut to workaround a
bug in Electron (electron/electron#1334).

We can remove `electron-localshortcut` once that bug is fixed.
@feross feross closed this as completed in 7eeda57 Mar 6, 2016
feross added a commit that referenced this issue Mar 6, 2016
@feross
Merge pull request #31 from feross/fix-26
fd300ed 
Add alternate fullscreen shortcut ⌘+Shift+F (fix #26)
@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross and others