Ws 119/admin listing page #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajrussellaudio
suggested changes
Mar 4, 2021
There was a problem hiding this comment.
Lots of comments but it looks great overall.
A couple of general concerns that won't block anything here:
- The lack of tests here gives me The Fear
- I've used styled-components in my half of this task, you've gone for regular CSS here. It makes no difference to me which way we go, but we should pick one and migrate the other over.
Merged
…thub.com/wellcomecollection/wellcomecollection.org into WS-119/admin-listing-page � Conflicts: � identity-admin/webapp/package.json � identity-admin/webapp/pages/_app.tsx � identity-admin/webapp/pages/index.tsx � identity-admin/webapp/yarn.lock
ajrussellaudio
suggested changes
Mar 10, 2021
…mecollection.org into WS-119/admin-listing-page
robmarch2
requested review from
davidpmccormick,
gestchild and
jamesgorrie
as code owners
ajrussellaudio
suggested changes
Mar 30, 2021
identity-admin/webapp/components/search/StatusDropdown.test.tsx
Outdated
Show resolved
Hide resolved
identity-admin/webapp/components/search/StatusDropdown.test.tsx
Outdated
Show resolved
Hide resolved
identity-admin/webapp/components/search/StatusDropdown.test.tsx
Outdated
Show resolved
Hide resolved
…thub.com/wellcomecollection/wellcomecollection.org into WS-119/admin-listing-page � Conflicts: � yarn.lock
ajrussellaudio
suggested changes
Apr 1, 2021
Comment on lines
162
to
163
| background-color: rgb(233, 236, 239); | ||
| color: grey; |
There was a problem hiding this comment.
This is equivalent to:
background-color: #E9ECEF;
color: #808080;This doesn't meet contrast guidelines. The text should be #696969 or darker, which I think still makes it obvious that the link is disabled:
ajrussellaudio
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.