Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

Release 1.0.1 #231

Merged
merged 8 commits into from
Feb 24, 2021
Merged

Release 1.0.1 #231

merged 8 commits into from
Feb 24, 2021

Conversation

aCampello
Copy link
Contributor

@aCampello aCampello commented Feb 24, 2021

Release checklist

  • Change wellcomeml/__version__.py
  • Add changelog
  • make dist
  • Verify new package was generated correctly on the pip registry
    and GitHub releases
  • "Yank" CalVER versions on pyPi registry
  • Make sure pip install wellcomeml install correct version

Fixes https://github.com/wellcometrust/WellcomeML/issues/160

@@ -1,5 +1,5 @@
__name__ = "wellcomeml"
__version__ = "2021.2.1"
__version__ = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@nsorros nsorros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when you tick all the boxes

@aCampello
Copy link
Contributor Author

make dist works uneventfully

@aCampello
Copy link
Contributor Author

Pypi complained about 1.0.0

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse for more information.

Probably something to do with the fact that I used 1.0.0 before for test... investigating

@aCampello
Copy link
Contributor Author

Well this is awkward, seems that PyPI is not enjoying 1.0.0 because there was a test one created in the past. Will figure out if there is anyway to by pass it unless we'll have to be 1.0.1 or something!

@aCampello
Copy link
Contributor Author

Ok, for a number of reasons it seems that we won't be able to release 1.0.0 on pypi, since in the past there was a 1.0.0 deleted.

pypa/packaging-problems#74

@nsorros
Copy link
Contributor

nsorros commented Feb 24, 2021

Ok, for a number of reasons it seems that we won't be able to release 1.0.0 on pypi, since in the past there was a 1.0.0 deleted.

pypa/packaging-problems#74

Yep, releases are not mutable. If they were that would be a problem since one day a library you installed by pinning a version worked and the other it did not out of no fault of your own. 1.0.1 it is.

In the future btw if you want to test something, PyPi recommends doing it in a test account. I also have a test account which I used when we first released wellcomeml

@aCampello
Copy link
Contributor Author

Yes, that was mea culpa. I was too sloppy with the test.

@aCampello aCampello changed the title Release 1.0.0 Release 1.0.1 Feb 24, 2021
@aCampello
Copy link
Contributor Author

Running make dist again....

@aCampello
Copy link
Contributor Author

Pip install outputs:

> pip freeze | grep wellcomeml
wellcomeml==1.0.1

@aCampello
Copy link
Contributor Author

Trying to pip install old versions now. Pip installing pinned versions work:

pip install wellcomeml==2020.9.0 --no-cache-dir

Returns

pip freeze | grep wellcomeml
wellcomeml==2020.9.0

Note that assignments like wellcomeml < 2020.9.0 won't work. User will have to pin the exact version.

@aCampello
Copy link
Contributor Author

Incidentally, this PR fixes https://github.com/wellcometrust/WellcomeML/issues/160

@aCampello aCampello merged commit a804ba7 into master Feb 24, 2021
@aCampello aCampello deleted the release-1.0.0 branch February 24, 2021 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix license
3 participants