-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
wellcomeml/__version__.py
Outdated
@@ -1,5 +1,5 @@ | |||
__name__ = "wellcomeml" | |||
__version__ = "2021.2.1" | |||
__version__ = "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge when you tick all the boxes
|
Pypi complained about 1.0.0 HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse for more information. Probably something to do with the fact that I used 1.0.0 before for test... investigating |
Well this is awkward, seems that PyPI is not enjoying 1.0.0 because there was a test one created in the past. Will figure out if there is anyway to by pass it unless we'll have to be 1.0.1 or something! |
Ok, for a number of reasons it seems that we won't be able to release 1.0.0 on pypi, since in the past there was a 1.0.0 deleted. |
Yep, releases are not mutable. If they were that would be a problem since one day a library you installed by pinning a version worked and the other it did not out of no fault of your own. 1.0.1 it is. In the future btw if you want to test something, PyPi recommends doing it in a test account. I also have a test account which I used when we first released wellcomeml |
Yes, that was mea culpa. I was too sloppy with the test. |
Running make dist again.... |
Pip install outputs:
|
Trying to pip install old versions now. Pip installing pinned versions work:
Returns
Note that assignments like |
Incidentally, this PR fixes https://github.com/wellcometrust/WellcomeML/issues/160 |
Release checklist
wellcomeml/__version__.py
make dist
and GitHub releases
pip install wellcomeml
install correct versionFixes https://github.com/wellcometrust/WellcomeML/issues/160