Don't timeout if the completion variable is already set #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 145 145
Branches 20 20
=========================================
Hits 145 145
Continue to review full report at Codecov.
|
westy92
requested changes
Nov 15, 2020
src/CompletionTriggers/Variable.ts
Outdated
| @@ -29,10 +29,15 @@ export class Variable extends CompletionTrigger { | |||
| awaitPromise: true, | |||
| expression: ` | |||
| new Promise((resolve, reject) => { | |||
| Object.defineProperty(window, '${varName}', { | |||
| if (window[${JSON.stringify(varName)}] === true) { | |||
There was a problem hiding this comment.
What advantages are there to using ${JSON.stringify(varName)} over ${varName}?
|
@Congelli501 have you had a chance to review my comments? |
|
I made my desired changes. Thank you for your contribution! 🎉 |
westy92
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.