Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the main HTTP request response. #299

Merged
merged 1 commit into from
May 10, 2021
Merged

Expose the main HTTP request response. #299

merged 1 commit into from
May 10, 2021

Conversation

westy92
Copy link
Owner

@westy92 westy92 commented May 10, 2021

This allows you to inspect the main HTTP response to decide if you want to save the generated PDF or not. For example, you may wish to retry if the response is 4xx or 5xx, even though some content is received from the server.

Note that the response is optional and won't be added if you are supplying HTML directly. See added test cases for examples.

@westy92 westy92 self-assigned this May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #299 (c24d2ef) into master (4a7eed4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        11    +1     
  Lines          174       185   +11     
  Branches        24        26    +2     
=========================================
+ Hits           174       185   +11     
Impacted Files Coverage Δ
src/CompletionTriggers/CompletionTrigger.ts 100.00% <ø> (ø)
src/ConnectionLostError.ts 100.00% <100.00%> (ø)
src/CreateResult.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bd4d7...c24d2ef. Read the comment docs.

@westy92 westy92 merged commit 6f803c4 into master May 10, 2021
@westy92 westy92 deleted the expose-response branch May 10, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant