Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multiple tabs #61

Closed
wants to merge 8 commits into from
Closed

Conversation

graingert
Copy link

No description provided.

@graingert
Copy link
Author

@westy92 this aims to be a port of @rhyek's parallel tab changes from #24

@graingert
Copy link
Author

const chrome = await htmlPdf.init(chromeOptions);

...
await htmlPdf.create(chrome, html, options);

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         108    109    +1     
  Branches       12     12           
=====================================
+ Hits          108    109    +1
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907c6a2...be35063. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         108    117    +9     
  Branches       12     12           
=====================================
+ Hits          108    117    +9
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907c6a2...9e0550d. Read the comment docs.

@graingert graingert force-pushed the use-multiple-tabs branch 5 times, most recently from 6bea09d to 335d0ea Compare September 25, 2017 18:37
@graingert
Copy link
Author

@westy92 this PR is ready to go, I've created a subset of this PR here because I cannot get the tests to pass reliably (even on master)

@graingert graingert mentioned this pull request Sep 25, 2017
Thomas Grainger added 5 commits September 28, 2017 12:56
required so retried flakey tests don't try to restub.
if a test times out it will not close the connection to the underlying
chrome. This means other tests can't connect.
@miguelduarte42
Copy link

Any idea when this PR will be finalised?

@westy92
Copy link
Owner

westy92 commented Nov 6, 2017

@graingert can you sync up with master and we can work to get this merged? Tests have been stabilized, so the only changes that should be needed there are the addition of any new tests. Thanks!

@graingert
Copy link
Author

@westy92 sorry, I've not got time to work on this PR (I'm using puppeteer now)

@westy92
Copy link
Owner

westy92 commented Nov 6, 2017

This inspired changes that landed in 89f63ad and will be released with v0.5.0.

@westy92 westy92 closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants