-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use multiple tabs #61
Conversation
const chrome = await htmlPdf.init(chromeOptions);
...
await htmlPdf.create(chrome, html, options); |
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 108 109 +1
Branches 12 12
=====================================
+ Hits 108 109 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 108 117 +9
Branches 12 12
=====================================
+ Hits 108 117 +9
Continue to review full report at Codecov.
|
6bea09d
to
335d0ea
Compare
required so retried flakey tests don't try to restub.
if a test times out it will not close the connection to the underlying chrome. This means other tests can't connect.
335d0ea
to
61317c4
Compare
c0a6a07
to
9e0550d
Compare
Any idea when this PR will be finalised? |
@graingert can you sync up with master and we can work to get this merged? Tests have been stabilized, so the only changes that should be needed there are the addition of any new tests. Thanks! |
@westy92 sorry, I've not got time to work on this PR (I'm using puppeteer now) |
This inspired changes that landed in 89f63ad and will be released with v0.5.0. |
No description provided.