Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask SDK not working properly #4367

Closed
1 task done
kr-keshav-kk opened this issue Oct 28, 2024 · 4 comments
Closed
1 task done

Metamask SDK not working properly #4367

kr-keshav-kk opened this issue Oct 28, 2024 · 4 comments
Labels
Needs Reproduction Misc: Needs Reproduction

Comments

@kr-keshav-kk
Copy link

kr-keshav-kk commented Oct 28, 2024

Check existing issues

Describe the bug

I am using vanilla js of wagmi with svelte kit.

I have implemented coinbase and walletConnect sdk and they are working fine.
But for metamask i have to call this function twice (calling it even number of times, it works).
First time clicking gives this warning:
MetaMaskSDK: No active provider found
image
Next time it upon clicking it works as expected.

This is the function that i have to call twice
await connect(wagmiConfig, { connector:metaMask() });

Link to Minimal Reproducible Example

https://stackblitz.com/edit/sveltejs-kit-template-default-2piuac?file=src%2Froutes%2F%2Bpage.svelte

try npm ci if it stackblitz is not able to run the website

Steps To Reproduce

wagmiConfig = createConfig({ chains: supportedChains, connectors: [ metaMask(), coinbaseWallet(), walletConnect({ projectId: PUBLIC_WALLET_CONNECT_ID, }), injected(), ], transports: supportedTransports, });

the next part is inside button click:

`await connect(wagmiConfig, {
		connector:metaMask(),
	});`

What Wagmi package(s) are you using?

@wagmi/connectors, @wagmi/core

Wagmi Package(s) Version(s)

"@wagmi/connectors": "^5.2.1", "@wagmi/core": "^2.13.8",

Viem Version

"viem": "^2.21.27"

TypeScript Version

"typescript": "^5.6.3",

Anything else?

No response

@tmm tmm added the Needs Reproduction Misc: Needs Reproduction label Oct 28, 2024
Copy link
Contributor

Hello @kr-keshav-kk.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config/environment and issue, and allow us to help you faster.

Once a minimal reproduction is added, a team member will confirm it works, then re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 28, 2024
@kr-keshav-kk kr-keshav-kk changed the title Metamask SDK not working properly Metamask SDK not working properly --added minimal reproduction Oct 28, 2024
@kr-keshav-kk
Copy link
Author

@tmm can you check again?? I have added minimal reproduction

@kr-keshav-kk
Copy link
Author

can someone reopen this issue? I have added the minimal reproduction code.
@1997roylee @tmm @jxom

@tmm tmm reopened this Nov 6, 2024
@kr-keshav-kk kr-keshav-kk changed the title Metamask SDK not working properly --added minimal reproduction Metamask SDK not working properly Nov 6, 2024
@tmm tmm closed this as completed in d091cf0 Nov 6, 2024
tmm added a commit that referenced this issue Nov 6, 2024
Nichebiche added a commit to Nichebiche/wagmi that referenced this issue Nov 8, 2024
* fix: wevm#4140

* chore: update mipd

* chore: version packages (wevm#4141)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: `useWatchAsset` hook (wevm#4128)

* feat: `useWatchAsset` hook

* test: add tests

* docs: add docs

* nit: use `getConnectorClient`

* fix: types

* test: fix

* test: fix

* test: fix

* chore: tweaks

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* feat(vue): useBytecode (wevm#4145)

* feat: useBytecode

* docs: tweak the composable example for vue

* docs: use missing code highlighting for the TSQ Vue examples

* chore: fix tests

* chore: changeset

---------

Co-authored-by: Skas Merkushin <[email protected]>

* chore: version packages (wevm#4144)

* chore: version packages

* chore: correct version

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tom Meagher <[email protected]>

* chore: update `@safe-global/safe-apps-sdk` (wevm#4146)

chore: update safe

* chore: version packages (wevm#4147)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* docs: update write-to-contract.md (wevm#4148)

This section talk about minting using tokenId input name but the example code switch to using address as input name

* fix: wevm#4118

* fix: wevm#4150

* chore: format

* close: wevm#4151

* chore: types

* chore: version packages (wevm#4152)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* FIX: useConnectorClient to be enabled only when connected or reconnecting (wevm#4124)

* update enabled param for useConnectorClient and add a test

* bring updated hook

* change set

* apply review

* chore: version packages (wevm#4155)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update useEstimateGas.md (wevm#4156)

* feat: propagate transport rpc urls to connectors (wevm#4162)

* feat: propagate transport rpc urls to connectors

* tests: update snaps

* chore: tweak changeset

* chore: version packages (wevm#4163)

* chore: version packages

* Update package.json

* Update CHANGELOG.md

* Update version.ts

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: jxom <[email protected]>

* chore: add sponsor

* fix: wevm#4169

* chore: format

* test: chore

* chore: format

* chore: version packages (wevm#4170)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* test: createConfig restore unconfigured chainId

* chore: bump deps

* chore: bump deps

* chore: version packages (wevm#4182)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update AppKit guide link (wevm#4190)

* fix: wevm#4097

* chore: version packages (wevm#4191)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat: validate internal state for persisted chainId

* chore: version packages (wevm#4192)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: gg21

* chore: format

* chore: add sponsor

* docs: tweak

* fix: wevm#4196

* chore: version packages (wevm#4197)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fixed the wrong input boxes. (wevm#4199)

Removed input boxes with input of Address and Value.
Added input boxes with input of tokenId.

* docs: tweaks

* chore: update ethereum provider to 2.15.0 (wevm#4208)

* chore: update ethereum provider to 2.15.0

* chore: add changeset file

* Update .changeset/neat-pants-care.md

---------

Co-authored-by: awkweb <[email protected]>

* fix: metaMask dappMetadata add default value (wevm#4203)

* fix: add name for mm connector (wevm#4211)

* fix: metaMask dappMetadata add default value

* chore: changeset

---------

Co-authored-by: rich.eth <[email protected]>

* chore: version packages (wevm#4212)

* Update @walletconnect/ethereum-provider to 2.15.1 (wevm#4213)

* chore: update @walletconnect/ethereum-provider to 2.15.1

* chore: ammend changeset to match convention

* chore: version packages (wevm#4214)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: remove gc banner

* chore: sponsors

* chore: sponsor

* chore(connectors): bump wc provider

* chore: version packages (wevm#4232)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* docs: up

* chore: update @walletconnect/ethehreum-provider to version 2.15.3 (wevm#4243)

* chore: updates @walletconnect/ethehreum-provider to version 2.15.3

* Update .changeset/slow-moose-unite.md

---------

Co-authored-by: awkweb <[email protected]>

* test: setup connector

* test: remove

* chore: bump mm sdk (wevm#4251)

* feat: update sdk

* chore: format

* chore: tweaks

* chore: changeset

---------

Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: abretonc7s <[email protected]>

* chore: version packages (wevm#4250)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(vue): useWatchContractEvent (wevm#4252)

* feat(vue): useWatchContractEvent

* chore: snaps

* test: boost

* chore: format

* chore: tweaks

* chore: version packages (wevm#4253)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: guard (get|use)ConnectorClient when reconnecting (wevm#4259)

* feat: connector client reconnection

* chore: changeset

* chore: snaps

* fix(react,vue): useReadContract deployless reads (wevm#4260)

* fix(react,vue): deployless reads

* chore: changeset

* chore: Update ethereum-provider to version 2.16.1 (wevm#4255)

* chore: update @walletconnect/ethereum-provider to 2.16.1

* chore: add changeset

* Update .changeset/empty-falcons-approve.md

---------

Co-authored-by: awkweb <[email protected]>

* chore: version packages (wevm#4261)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add experimental actions export to react package (wevm#4262)

* Add experimental actions export to react package

* chore: add vue entrypoint

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: fix exports

* chore: version packages (wevm#4263)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* docs: fix typos (wevm#4264)

* fix typo

* fix typos

* fix typos

* fix typo

* fix typo

* feat: update the 'metamask-sdk' package to version '0.28.4' (wevm#4271)

* feat: update metamask-sdk package to version 0.28.4

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* fix: allow detection of hardhat when using bun (wevm#4224)

* fix: allow detection of hardhat when using bun

- added the user agent check now that bun supports it when finding the package manager
- since bun does not have an ls command similar to the others, we check all installed packaged (--all is needed in monorepos) and check it it contains hardhat

* chore: tweaks

---------

Co-authored-by: Tom Meagher <[email protected]>

* Fix the switchChain error encountered when using the "metaMask" connector (wevm#4227)

* fix: metaMask switchChain

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: version packages (wevm#4278)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: remove duplicate extend in getWalletClient (wevm#4286)

* chore: remove duplicate extend

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: version packages (wevm#4289)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: guard against missing provider.on

* chore: version packages (wevm#4294)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: prevent component re-rendering with the same account snapshot (wevm#4229)

* fix: prevent component re-rendering with the same account snapshot

* test: check component re-rendering caused by useSyncExternalStoreWithTracked

* test: update

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* test: boost coverage

* chore: version packages (wevm#4299)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix race condition in injected.ts (wevm#4207)

* Fix race condition in injected.ts

It can hangs if "once" catches an event with unexpected chainId

* chore: tweaks

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: version packages (wevm#4300)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: bump dev deps (wevm#4302)

* chore: bump dev deps

* chore: bump vitest

* chore: format

* chore: bump

* chore: tweaks

---------

Co-authored-by: tmm <[email protected]>

* test: up

* test: cov

* chore: format

* test: skip

* chore: bump deps

* chore: snaps

* chore: fix script

* chore: version packages (wevm#4315)

* docs: tweaks

* feat: bump mm sdk (wevm#4337)

* feat: update metamask sdk and implement connectSign

* feat: cleanup

* feat: cleanup

* sdk 0.29.1

* feat: cleanup

* feat: url default

* feat: prevent breaking changes

* feat: cleanup

* chore: tweaks

* chore: tweaks

* chore: format

* chore: changeset

---------

Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: tmm <[email protected]>

* test: snaps

* chore: version packages (wevm#4342)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: bump mm (wevm#4345)

* chore: bump mm sdk

* chore: changeset

* chore: version packages (wevm#4346)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: uniswap wallet trying to make itself look like MetaMask (wevm#4336)

* fix: uniswap wallet trying to make itself look like MetaMask

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* test: mock reconnect

* chore: format

* chore: viem tweaks

* chore: up viem

* chore: up snaps

* fix: MetaMask disconnecting during the connection process. (wevm#4347)

* fix: disconnection during the connection process.

* fix: disconnection during the connection process.

* chore: tweaks

* chore: changeset

* chore: comment

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: add codeowners

* feat: bump metamask 0.30.0 (wevm#4350)

* feat: bump metamask 0.30.0

* feat: add changeset

* Update .changeset/tasty-clouds-kiss.md

Co-authored-by: awkweb <[email protected]>

* Update .changeset/tasty-clouds-kiss.md

---------

Co-authored-by: awkweb <[email protected]>

* chore: version packages (wevm#4348)

* feat(connectors): filter mipd by connector rdns (wevm#4343)

* feat(connectors): filter mipd by connector rdns

* feat: add connect listeners

* test: boost coverage

* test(core): eip 6963 announce

* test: tweaks

* chore: format

* chore: changeset

* feat: works with ssr flag

* chore: changeset

* chore: tweaks

---------

Co-authored-by: tmm <[email protected]>

* chore: skip

* chore: version packages (wevm#4354)

* chore: version packages

* chore: fix version

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tom Meagher <[email protected]>

* chore: up version

* chore(core): bump internal deps (wevm#4349)

chore: bump deps

* feat(core): mock defaultConnected

* chore: version packages (wevm#4355)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* test: tweak

* chore: clean up deps (wevm#4357)

* chore: clean up deps

* chore: types

* chore: changeset

* chore: bump deps

* chore: version packages (wevm#4359)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: boost coverage

* ci: protected push

* feat: export type

* chore: version packages (wevm#4361)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: MetaMask readonlyRPCMap type (wevm#4362)

* fix: MetaMask readonlyRPCMap type

* chore: tweaks

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: version packages (wevm#4363)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* test: up

* chore: add sponsor

* docs: bump deps

* chore(cli): bump chokidar (wevm#4370)

* chore: bump chokidar

* chore: fmt

* chore: changeset

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: version packages (wevm#4378)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: add sponsor

* fix: Safe connector not working in some Vite apps (wevm#4371)

* Fix Safe connector not working in some Vite apps

* Fix Safe connector not working in some Vite apps

* chore: tweaks

---------

Co-authored-by: Tom Meagher <[email protected]>

* fix: waitForTransactionReceipt proper eth_call usage (wevm#4339)

* fix: waitForTransactionReceipt proper eth_call usage

* chore: tweaks

---------

Co-authored-by: Tom Meagher <[email protected]>

* docs(cli/create-wagmi): template selection (wevm#4356)

* docs(cli/create-wagmi): template selection

Explain how to select the template when you don't specify `--template` or `-t`, and what each option means.

* docs: up

---------

Co-authored-by: Tom Meagher <[email protected]>

* chore: snaps

* fix: wevm#4353

* docs: close wevm#4344

* chore: snaps

* chore: version packages (wevm#4380)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* docs: rpc

* fix: wevm#4310

* fix: wevm#4367

* chore: version packages (wevm#4383)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: pnpm catalogs

* chore: tweaks

* chore: bump dependencies (wevm#4385)

* chore: bump dependencies

* Update .changeset/four-pens-collect.md

---------

Co-authored-by: Jake <=>
Co-authored-by: awkweb <[email protected]>

* chore: fix types

* chore: version packages (wevm#4387)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: snaps

* fix: injected connector throws error after switching to a chain that was just added via `'wallet_addEthereumChain'`. (wevm#4311)

* fix: injected connector throwing error after switching to a chain that was just added via `'wallet_addEthereumChain'`.

* chore: changeset

* chore: tweaks

---------

Co-authored-by: Tom Meagher <[email protected]>

* test: tweaks

* chore: version packages (wevm#4388)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Tom Meagher <[email protected]>
Co-authored-by: jxom <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vladyslav Dalechyn <[email protected]>
Co-authored-by: Skas Merkushin <[email protected]>
Co-authored-by: Samson Adesanoye <[email protected]>
Co-authored-by: tmm <[email protected]>
Co-authored-by: t0rbik <[email protected]>
Co-authored-by: wy <[email protected]>
Co-authored-by: Radek Sienkiewicz <[email protected]>
Co-authored-by: Vedant-asati <[email protected]>
Co-authored-by: tomiir <[email protected]>
Co-authored-by: rich.eth <[email protected]>
Co-authored-by: rich.eth <[email protected]>
Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: abretonc7s <[email protected]>
Co-authored-by: Łukasz Stankiewicz <[email protected]>
Co-authored-by: omahs <[email protected]>
Co-authored-by: Omri Dan <[email protected]>
Co-authored-by: Roderik van der Veer <[email protected]>
Co-authored-by: 闲尘 <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Weil Liao <[email protected]>
Co-authored-by: Dmitry Blues <[email protected]>
Co-authored-by: Edouard Bougon <[email protected]>
Co-authored-by: v1rtl <[email protected]>
Co-authored-by: Ice and dust <[email protected]>
Co-authored-by: insomnia.exe <[email protected]>
Co-authored-by: Ori Pomerantz <[email protected]>
Co-authored-by: cb-jake <[email protected]>
Co-authored-by: Eugene Chybisov <[email protected]>
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants