Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve chain switching via MetaMask connector #4397

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

christopherferreira9
Copy link

@christopherferreira9 christopherferreira9 commented Nov 11, 2024

This PR aims to solve an issue where the original logic of switchChain -> add if it's not present would cause an extra back and forth between dapp and the MetaMask wallet, particularly on Mobile to Mobile interactions.

  • Adds a retry to the eth_chainId call to avoid a race condition

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 078e247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@christopherferreira9 christopherferreira9 marked this pull request as draft November 11, 2024 13:29
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 2:06am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants