Make it clearer that cache mode "default" follows normal logic #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cache mode is “default” and you set a Cache-Control header, that should be taken into account when talking to the HTTP cache subsystem. It’s how the cache works by “default”, after all. Fixes #336.
annevk
force-pushed
the
cache-mode-default
branch
from
60e6caf to
29b5802
Compare
|
@ehsan does this look okay? |
|
@mnot any thoughts? I was wondering, would it help to start a thread on the HTTP mailing list about better integration between the documents? |
|
FWIW, I thought we already had "default" doing whatever the cache-control headers said to do. That's what we implement. |
|
I know, but it's not clear from the specification as new implementations got it wrong. That's why I'm trying to get these changes reviewed. |
|
Acknowledge when landing this: Ali Alabbas. I'm starting to think there's probably room for a more expansive section on the HTTP cache to also deal with the credentials issue. I'll wait a bit for @mnot to poke around before doing anything about it though. |
|
This is superseded by the rewrite in #496. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cache mode is “default” and you set a Cache-Control header, that
should be taken into account when talking to the HTTP cache subsystem.
It’s how the cache works by “default”, after all.
Fixes #336.