-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window's time origin is totally different across browsers. Consider simplifying #7716
Comments
I agree that this would be a step in the right direction. w3c/navigation-timing#160 (comment) (by you!) has notes on potentially making it even better. (I say potentially, as perhaps WebKit already uses the start time of the latest fetch.) |
Yea, that would be better IMO but more "breaking" in case of a navigation that starts with a cross-origin redirect. |
I certainly wouldn't oppose putting WebKit's current behavior into the spec as a less shocking change for some browsers on our way to solving navigation-timing issue 160 |
No need to measure timestamp during navigation and account for unload prompts. Fetch already measures the startTime. Patch it through to `document load info` which is in turn accessed by the `environment settings object`. This is in line with current WebKit implementation, and very close to Chromium implementation which currently doesn't count beforeunload time as part of the navigation time. Closes whatwg#7716
Who is the right person on the Chromium or Gecko sides to make the call here? |
|
No need to measure timestamp during navigation and account for unload prompts. Fetch already measures the startTime. Patch it through to `document load info` which is in turn accessed by the `environment settings object`. This is in line with current WebKit implementation, and very close to Chromium implementation which currently doesn't count beforeunload time as part of the navigation time. Closes whatwg#7716
I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1316609 |
We are onboard about changes and will use https://bugzilla.mozilla.org/show_bug.cgi?id=1760010 to make the change. We'll also verify the results to make sure there's no big shift in the data. |
Pages that would have a disruption would have a |
No need to measure timestamp during navigation and account for unload prompts. Fetch already measures the startTime. Patch it through to `document load info` which is in turn accessed by the `environment settings object`. This is in line with current WebKit implementation, and very close to Chromium implementation which currently doesn't count beforeunload time as part of the navigation time. Closes whatwg#7716
There's no need to measure the timestamp during navigation and account for beforeunload prompts. We can just use the start time already measured by Fetch. This is in line with current WebKit implementation, and very close to Chromium implementation which currently doesn't count beforeunload time as part of the navigation time. Closes #7716.
There's no need to measure the timestamp during navigation and account for beforeunload prompts. We can just use the start time already measured by Fetch. This is in line with current WebKit implementation, and very close to Chromium implementation which currently doesn't count beforeunload time as part of the navigation time. Closes whatwg#7716.
Currently
timeOrigin
forwindow
environments is specified as being right before thebeforeunload
events, or right after confirmation of the unload. However, implementations don't follow this at all!beforeunload
event is handled regardless of promptsbeforeunload
event even in the case of prompt (see https://bugzilla.mozilla.org/show_bug.cgi?id=1760010)This can lead to confusion and for totally different numbers across websites and between browsers (especially Firefox).
Suggesting to simplify the spec to use WebKit's approach, essentially navigation start time = underlying resource fetch start time = 0 (the time origin)
The text was updated successfully, but these errors were encountered: