-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "can have its URL rewritten" to be scheme-based #7044
Conversation
|
||
<p>Note how only the <span data-x="concept-document-url">URL</span> of the <code>Document</code> | ||
matters, and not its <span data-x="concept-document-origin">origin</span>. They can mismatch in | ||
cases like the <span data-x="is initial about:blank">initial <code>about:blank</code></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just "about:blank documents with inherited origins" in general?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are always initial, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM with one suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could list document.domain as another example of not affecting this API. (Which seems like the right thing to me.)
…ing, a=testonly Automatic update from web-platform-tests Tests for history.pushState() URL rewriting See whatwg/html#6836. Follows whatwg/html#7044. -- wpt-commits: 130d57f9a1d6f4f51bb9bd81444978efad7016ce wpt-pr: 30182
…ing, a=testonly Automatic update from web-platform-tests Tests for history.pushState() URL rewriting See whatwg/html#6836. Follows whatwg/html#7044. -- wpt-commits: 130d57f9a1d6f4f51bb9bd81444978efad7016ce wpt-pr: 30182
Closes #6836. Closes #6992 by superseding it.
(See WHATWG Working Mode: Changes for more details.)
/history.html ( diff )