Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "can have its URL rewritten" to be scheme-based #7044

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 8, 2021

Closes #6836. Closes #6992 by superseding it.

(See WHATWG Working Mode: Changes for more details.)


/history.html ( diff )

@domenic domenic added normative change topic: history interop Implementations are not interoperable with each other labels Sep 8, 2021
@domenic domenic requested review from annevk and rakina September 8, 2021 17:43

<p>Note how only the <span data-x="concept-document-url">URL</span> of the <code>Document</code>
matters, and not its <span data-x="concept-document-origin">origin</span>. They can mismatch in
cases like the <span data-x="is initial about:blank">initial <code>about:blank</code></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "about:blank documents with inherited origins" in general?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are always initial, right?

Copy link
Member

@rakina rakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM with one suggestion!

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could list document.domain as another example of not affecting this API. (Which seems like the right thing to me.)

domenic added a commit to web-platform-tests/wpt that referenced this pull request Sep 9, 2021
@domenic domenic merged commit d2976d0 into main Sep 9, 2021
@domenic domenic deleted the url-rewriting-take-2 branch September 9, 2021 17:37
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 22, 2021
…ing, a=testonly

Automatic update from web-platform-tests
Tests for history.pushState() URL rewriting

See whatwg/html#6836. Follows whatwg/html#7044.
--

wpt-commits: 130d57f9a1d6f4f51bb9bd81444978efad7016ce
wpt-pr: 30182
aosmond pushed a commit to aosmond/gecko that referenced this pull request Sep 24, 2021
…ing, a=testonly

Automatic update from web-platform-tests
Tests for history.pushState() URL rewriting

See whatwg/html#6836. Follows whatwg/html#7044.
--

wpt-commits: 130d57f9a1d6f4f51bb9bd81444978efad7016ce
wpt-pr: 30182
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other normative change topic: history
Development

Successfully merging this pull request may close these issues.

Newly created browsing contexts will almost always reject history.pushState/replaceState
3 participants