Limit Content-Type overrides to when charset isn't already UTF-8 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help web compatibility and address all cases linked from whatwg/mimesniff#84. Tests: ...
|
cc @wisniewskit |
annevk
added
the
needs tests
annevk
added a commit
to whatwg/mimesniff
that referenced
this pull request
Oct 16, 2018
This is a defense-in-depth for the issues that arised at #84. In theory they are all solved by whatwg/xhr#224, but given how quickly several sites turned up that relied on a space, it seems prudent to standardize on that serialization to avoid similar issues elsewhere.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2018
…ialization Tests for whatwg/xhr#224 and whatwg/mimesniff#86. They are combined in a single commit as otherwise there would be two rounds of changes to the XMLHttpRequest tests, while they are really supposed to be coupled.
domenic
approved these changes
Oct 16, 2018
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 18, 2018
…ialization Tests for whatwg/xhr#224 and whatwg/mimesniff#86. They are combined in a single commit as otherwise there would be two rounds of changes to the XMLHttpRequest tests, while they are really supposed to be coupled.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 30, 2018
For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544.
annevk
removed
the
needs tests
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 30, 2018
For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 10, 2018
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779
jyc
pushed a commit
to jyc/gecko
that referenced
this pull request
Nov 11, 2018
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779
domenic
pushed a commit
to jsdom/jsdom
that referenced
this pull request
May 28, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…less, a=testonly Automatic update from web-platform-testsXMLHttpRequest: manipulate Content-Type less For whatwg/xhr#224 and in particular whatwg/mimesniff#84. This supersedes and closes #13544. -- wpt-commits: 99f4fdcd906411c036e96c055e28b3e6ca84a1cc wpt-pr: 13779 UltraBlame original commit: f5b3c921363e751e6ad363970bd7727701d59525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help web compatibility and address all cases linked from whatwg/mimesniff#84.
Tests: ...
Preview | Diff