Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Wiktionary to use Coroutine and ViewModel #4628

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Refactoring Wiktionary to use Coroutine and ViewModel #4628

merged 4 commits into from
Apr 29, 2024

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Apr 26, 2024

  • Use coroutine and ViewModel.
  • Update the logic of showing ProgressBar and ErrorView to match the current structure.
  • Update RbDefinition to remove usagesByLang.
  • Add a new ARG_TEXT in Constants to send plain text.
  • Use response[pageTitle.wikiSite.languageCode] instead of a hard-coded "en" when mapping.

@cooltey cooltey added the Ready to merge PR passed design signoff and ready to be merged. label Apr 26, 2024
@dbrant dbrant merged commit 003e2d9 into main Apr 29, 2024
1 check passed
@dbrant dbrant deleted the wiktionary-coroutine-viewmodel branch April 29, 2024 13:12
@cooltey cooltey mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner

@sharvaniharan sharvaniharan Awaiting requested review from sharvaniharan

Assignees
No one assigned
Labels
Ready to merge PR passed design signoff and ready to be merged.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cooltey @dbrant