Feature branch: Recommended Content #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-android-wikipedia into recommended-content-design
|
@dbrant All comments were addressed. This is ready for review again. |
* Enforce end-date for Recommended Content experiment. * Use property. * Reinstate pre-beta.
dbrant
requested changes
Sep 4, 2024
…4916) * Use style instead of deprecated method for resizing dialog window. * Create child style. * Automatic parent. * Whoops.
dbrant
requested changes
Sep 4, 2024
app/src/main/java/org/wikipedia/recommendedcontent/RecommendedContentViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/wikipedia/recommendedcontent/RecommendedContentViewModel.kt
Outdated
Show resolved
Hide resolved
* main: Optimizing the NewsItem and OnThisDay variables (#4923)
cooltey
added
Ready to merge
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T370117
https://phabricator.wikimedia.org/T372761