Fix blocked message in Suggested Edits, and use coroutines. #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
commented
Aug 20, 2024
| @Test | ||
| @Throws(Throwable::class) | ||
| fun testRequestResponse404() { | ||
| enqueue404() |
There was a problem hiding this comment.
I removed the rest of these tests because I no longer understand what they're testing. Are they testing if Retrofit works correctly? That's already done in Retrofit's own test suite. Are they testing if the Java language works correctly? I'm not sure that's within the scope of what we should worry about.
cooltey
reviewed
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the Suggested Edits screen, if the current account is blocked, the block message overlaps the other components on the screen, because the other components are not properly hidden. This is most prominent in Black mode; in other modes it looks more correct, but only by accident.
This fixes the showing/hiding of the other components in case of a block, and while fixing the issue I converted some of the block message retrieval logic to coroutines, which will simplify the work of several upcoming tasks.