Allow users to clear locally stored donation history

[cesonha]

What does this do?

This will add a new preference in the SettingsFragment that enables the user to delete the local donation history. All this done respecting the business rules defined in the Phabricator ticket. The new preference only shows if the donation history is not empty and after the user deletes it the preference hides.

Why is this needed?

Please refer to the Phabricator's link Background section
Phabricator:
https://phabricator.wikimedia.org/T380662

Screenshot

[cesonha]

Hi everyone, this is my first contribution and I have some doubts that I would be happy to get some clarification:

• I saw that the iOS and Android Settings screen have a different UI and the preferences are organized in different sections, how can I know that the way I did is approved by the UX/UI team?
• What should I do regarding the translation/localization, do I need to do it by myself?
• What about unit tests, I understand that some classes might be easier to test than others, is there a discussion for that? I want to add tests to my PR but some guidance would be nice!
• Do we need a summary for this preference?

[cooltey]

Hi @cesonha, thanks for submitting the PR!

Hi everyone, this is my first contribution and I have some doubts that I would be happy to get some clarification:

* I saw that the iOS and Android Settings screen have a different UI and the preferences are organized in different sections, how can I know that the way I did is approved by the UX/UI team?

If you have claimed the ticket, you can tag HNordeenWMF or SChekfa-WMF by attaching the screenshot you have in the comment.

* What should I do regarding the translation/localization, do I need to do it by myself?

The way we add a translation, we will add the same <string name="..."> you have added to the default strings.xml to the qq/strings.xml, with a description of the string item.

* What about unit tests, I understand that some classes might be easier to test than others, is there a discussion for that? I want to add tests to my PR but some guidance would be nice!

I do not think this PR would need a test case.

* Do we need a summary for this preference?

You can put this comment in the Phabacator ticket and tag our PM ( the one who created the ticket).

[cesonha]

Thanks @cooltey , just did as you've said and commented in phabricator tagging them!

[cesonha]

Hi @cooltey, it seems to be approved by the design and product team :) I've rebased with the main branch and added the string descriptions as you've said we should, should I just wait for code review/testing? :) TY

[cooltey]

All looks good! Thanks for the updates.