Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code for ౡ and corresponding testcase #776

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

tuxnani
Copy link
Contributor

@tuxnani tuxnani commented May 14, 2024

added code for ౡ and corresponding testcase

@kartikm kartikm requested a review from amire80 May 18, 2024 14:44
@kartikm
Copy link
Member

kartikm commented May 18, 2024

@tuxnani It seems the test is failing for this PR. Can you check it?

Copy link
Contributor

@amire80 amire80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, approved by mistake earlier. A test is failing. The rule is probably incorrectly written.

@srish
Copy link
Member

srish commented Oct 2, 2024

@tuxnani ping! Would it be possible for you to fix the rule?

Changed more specific rule to come before less specific
@Nikerabbit
Copy link
Member

I thought it is order dependent, but it is still failing so it's something else.

@srish srish dismissed amire80’s stale review November 26, 2024 15:37

Change is ready for approaval

@srish srish merged commit 6c60abf into wikimedia:master Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants