feat: identify invalid captures (and other improvements) #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
commented
Mar 7, 2023
eladb
commented
Mar 7, 2023
eladb
changed the title
Chriscbr
approved these changes
Mar 7, 2023
Closed
Chriscbr
reviewed
Mar 9, 2023
Chriscbr
reviewed
Mar 15, 2023
Rewrite the algorithm which analyzes the expressions captured by inflight methods so that it is able to identify more cases and emit errors when captures cannot be qualified (i.e. a resource is captured but we cannot determine which operations are performed on it without static analysis). Merge all `inflight_ref_resource_*` valid tests into `resource_captures` and all negative tests as well.
eladb
force-pushed
the
eladb/fail-non-infer
branch
from
8c2f74c to
220f5ed
Compare
eladb
changed the title
|
@yoav-steinberg @Chriscbr can you take another look here? I think this is done. |
Chriscbr
approved these changes
Mar 15, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Congrats! 🚀 This was released in Wing 0.5.134. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1682 to identify cases where we cannot infer which operations are performed on a captured resource.
See positive/negative tests for examples.
Rewrite the algorithm which analyzes the expressions captured by inflight methods so that it is able to identify more cases and emit errors when captures cannot be qualified (i.e. a resource is captured but we cannot determine which operations are performed on it without static analysis).
For each method, we identify all expressions that start with
this.xxxand break them down into parts (using nested references). Then, we traverse the list of parts and split the expression into preflight and inflight. The preflight part is what we are capturing and the first inflight component qualifies which operations are performed on the captured object.Reorganized capture tests into
resource_captures(both under valid and invalid).This does not address #76 but it explicitly identifies these cases. We will follow up at some point with a way to allow users to explicitly qualify the reference.
By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.