Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Exclude hidden inputs from focusable elements #310

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

dtorras
Copy link
Contributor

@dtorras dtorras commented Mar 2, 2023

Currently, inputs with type hidden break tabbing inside the modal component.

This issue is already fixed (#225) in the main branch for a future major release but not in the current 1.x releases.

This PR fixes it the same way Jetstream fixed it before using x-trap laravel/jetstream#757

@PhiloNL PhiloNL merged commit 6aec30d into wire-elements:1.0.0 Mar 4, 2023
@PhiloNL
Copy link
Contributor

PhiloNL commented Mar 4, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants