-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!feat(backup): support crossplatform backup (CPB) POC [WPB-10575] #18273
Draft
vitorhugods
wants to merge
17
commits into
dev
Choose a base branch
from
feat/multiplatform-backup
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweiss-dev
changed the title
!feat(backup): support multiplatform backup POC [WPB-10575]
!feat(backup): support crossplatform backup (CPB) POC [WPB-10575]
Nov 22, 2024
yamilmedina
approved these changes
Nov 22, 2024
yamilmedina
requested review from
yamilmedina
and removed request for
yamilmedina
November 22, 2024 16:37
…p-metadata chore: multiplatform backup - add assets metadata (WPB-10575)
…ebapp into feat/multiplatform-backup
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal is to unify the backup format between all clients, so a backup can be used in different devices/platforms.
It would also be a step in the direction of sharing chat history between clients. As this backup format can be shared from client A to client B.
Checklist
Important Details for the Reviewers
This is a POC
Don't take everything seriously (especially the silly mistakes coming from a non TS/JS fluent person).
Focus on src/script/backup/BackupRepository.ts
The directory
TEMP-crossplatform-backup
is only temporary and will not live within wire-webapp repository. The idea is to publish a NPM artifact and remove these files from here. There's also some cleanup needed and most of these files will be removed from the artifact itself.Backup Logic
It's supposed to be exactly the same. The only difference will be that instead of doing
JSON.stringify
andTextEncode
, it will use this library to (de)serialize a common data format.What's actually expected from this PR?
Main feedback I'd like to have is about the general idea and the API itself. The interaction/contract between
MPBackupImporter
orMPBackupExporter
and the Web client.Does it feel idiomatic enough? How could I change the signature of functions to make it feel smoother?
Silly example
Here is the silly backup file, FWIW. Rename it to
.desktop_wbu
in order to import on Web. I just made it a ZIP in order to upload on Github 😎WBX-vitor_wire-2024-11-04_16-19-18.zip