fix: fix remote astro:assets caching logic (#8424)

withastro · Sep 6, 2023 · 61ad70f · 61ad70f
1 parent 923a443
commit 61ad70f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/empty-rings-bow.md b/.changeset/empty-rings-bow.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes remote assets caching logic to not use expired assets
diff --git a/packages/astro/src/assets/build/generate.ts b/packages/astro/src/assets/build/generate.ts
@@ -75,7 +75,7 @@ export async function generateImage(
 			const JSONData = JSON.parse(readFileSync(cachedFileURL, 'utf-8')) as RemoteCacheEntry;
 
 			// If the cache entry is not expired, use it
-			if (JSONData.expires < Date.now()) {
+			if (JSONData.expires > Date.now()) {
 				await fs.promises.writeFile(finalFileURL, Buffer.from(JSONData.data, 'base64'));
 
 				return {