fix: correctly check isOnline with port (#12706)

withastro · Dec 10, 2024 · f6c4214 · f6c4214
1 parent 3169593
commit f6c4214
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/wild-ducks-decide.md b/.changeset/wild-ducks-decide.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/upgrade': patch
+---
+
+Fixes a bug that caused registry URLs that specify a port to be incorrectly detected as offline.
diff --git a/packages/upgrade/src/actions/verify.ts b/packages/upgrade/src/actions/verify.ts
@@ -43,8 +43,8 @@ export async function verify(
 }
 
 function isOnline(registry: string): Promise<boolean> {
-	const { host } = new URL(registry);
-	return dns.lookup(host).then(
+	const { hostname } = new URL(registry);
+	return dns.lookup(hostname).then(
 		() => true,
 		() => false,
 	);