feat(sessions): implement ttl and flash #12693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
|
Can you update the RFC with the relative information, so we can review the PR? |
|
@ematipico the RFC has been updated |
ematipico
reviewed
Dec 9, 2024
Comment on lines
+2
to
+3
| Astro.session.flash('flash-value', `Flashed value at ${new Date().toISOString()}`); | ||
| return Astro.redirect('/'); |
There was a problem hiding this comment.
Can we add more cases, such as:
- usage with
Astro.rewrite - usage with the
next("/some-route")(the other form of rewrite): see if the value changes when the next middleware function read from.flash - usage with multiple middleware functions e.g.
sequence(fn1, fn2)
ematipico
approved these changes
Dec 10, 2024
| @@ -138,10 +147,19 @@ export class AstroSession<TDriver extends SessionDriverName = any> { | |||
| this.#cookieSet = true; | |||
| } | |||
| this.#data ??= new Map(); | |||
| this.#data.set(key, value); | |||
| const lifetime = ttl ?? this.#config.ttl; | |||
| const expires = typeof lifetime === 'number' ? Date.now() + lifetime * 1000 : lifetime; | |||
There was a problem hiding this comment.
Can we add a comment that explains the 1000?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for session data expiry. This includes:
ttlconfig optionttlargument tosetsession.flash(), which expires the data after the next requestTesting
Added unit tests
Docs