-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format astro files in examples #3862
Format astro files in examples #3862
Conversation
|
<nav></nav> | ||
<div class='wrapper mt4 mb4'> | ||
<h1>Page Not Found</h1> | ||
<p>Not found</p> | ||
</div> | ||
<footer /> | ||
<footer></footer> | ||
</body> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to the formatting changes, but isn't this file supposed to use the imported components? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Maybe it should be another PR?
This looks good! Just three things:
What I suggest we do is:
That way we can at least get this PR merged without needing to fix all the issues (that we'll definitely fix in the future, of course!). If you don't have time to do it, don't hesitate to tell me and I'll take over this, very happy to help on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, there was a few changes I wasn't sure of inside the portfolio
example but testing locally, there seems to be no issues! Once this is merged, another PR adding the commit to this file will be needed
Changes
This PR runs the prettier-plugin-astro on the example projects to close #3855.
I did this by first installing the plugin in the repo, then running
npx prettier --write ./examples/**/*.astro
, then reverting the setup commit (since we do not want to add it yet, as discussed in the issue).Testing
I have not had time to test all the examples, would very much appreciate if someone could help me with that! It should only be a formatting change but maybe we'll find some edgecase where it breaks behavior? EDIT: I guess the CI should take care of testing that anyways.
Docs
No docs change needed