-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document MDX optimize static logic #7221
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I find it really clear, and it helps A LOT!
Co-authored-by: Emanuele Stoppa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bluwy, I'm so excited you're writing internal documentation! 🙌
Caught some little grammar things, and tried to point out where I thought flow or structure could be more helpful.
Admittedly, now you're writing stuff that I understand less-well, so there are some things here that sound like they could be improved to my editing ear, but I might not know exactly HOW to do that in this domain.
So, just take my suggestions for consideration, but you'll still have to do the heavy lifting for me. 😅
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Thanks for checking some of my silly mistakes @sarah11918. Sorry you have to go through that, I should run through a grammar checker next time 😅 I've applied most of your suggestions except #7221 (comment) that I'd like to make sure you see it before merging this. |
Changes
Followup to #7151 (comment) suggested by @ematipico
This adds internal docs on how the MDX optimization feature work.
After writing this out, I have no idea if it makes things clearer 😅 I'm not the best explainer and it could be polished a bit more.
Testing
n/a
Docs
Adds internal documentation for how MDX optimization works.