chore: use biome to format JSON and JavaScript files

.eslintrc.cjs

@@ -1,98 +1,98 @@
 const { builtinModules } = require('module');
 
 module.exports = {
-  extends: [
-    'plugin:@typescript-eslint/recommended-type-checked',
-    'plugin:@typescript-eslint/stylistic-type-checked',
-    'prettier',
-  ],
-  parser: '@typescript-eslint/parser',
-  parserOptions: {
-    project: ['./packages/*/tsconfig.json', './tsconfig.eslint.json'],
-    tsconfigRootDir: __dirname,
-  },
-  plugins: ['@typescript-eslint', 'prettier', 'no-only-tests'],
-  rules: {
-    // These off/configured-differently-by-default rules fit well for us
-    '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
-    '@typescript-eslint/no-unused-vars': [
-      'error',
-      { argsIgnorePattern: '^_', ignoreRestSiblings: true },
-    ],
-    'no-only-tests/no-only-tests': 'error',
-    '@typescript-eslint/no-shadow': ['error'],
-    'no-console': 'warn',
+	extends: [
+		'plugin:@typescript-eslint/recommended-type-checked',
+		'plugin:@typescript-eslint/stylistic-type-checked',
+		'prettier',
+	],
+	parser: '@typescript-eslint/parser',
+	parserOptions: {
+		project: ['./packages/*/tsconfig.json', './tsconfig.eslint.json'],
+		tsconfigRootDir: __dirname,
+	},
+	plugins: ['@typescript-eslint', 'prettier', 'no-only-tests'],
+	rules: {
+		// These off/configured-differently-by-default rules fit well for us
+		'@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
+		'@typescript-eslint/no-unused-vars': [
+			'error',
+			{ argsIgnorePattern: '^_', ignoreRestSiblings: true },
+		],
+		'no-only-tests/no-only-tests': 'error',
+		'@typescript-eslint/no-shadow': ['error'],
+		'no-console': 'warn',
 
-    // Todo: do we want these?
-    '@typescript-eslint/array-type': 'off',
-    '@typescript-eslint/ban-ts-comment': 'off',
-    '@typescript-eslint/class-literal-property-style': 'off',
-    '@typescript-eslint/consistent-indexed-object-style': 'off',
-    '@typescript-eslint/consistent-type-definitions': 'off',
-    '@typescript-eslint/dot-notation': 'off',
-    '@typescript-eslint/no-base-to-string': 'off',
-    '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/no-floating-promises': 'off',
-    '@typescript-eslint/no-misused-promises': 'off',
-    '@typescript-eslint/no-redundant-type-constituents': 'off',
-    '@typescript-eslint/no-this-alias': 'off',
-    '@typescript-eslint/no-unsafe-argument': 'off',
-    '@typescript-eslint/no-unsafe-assignment': 'off',
-    '@typescript-eslint/no-unsafe-call': 'off',
-    '@typescript-eslint/no-unsafe-member-access': 'off',
-    '@typescript-eslint/no-unsafe-return': 'off',
-    '@typescript-eslint/prefer-nullish-coalescing': 'off',
-    '@typescript-eslint/prefer-optional-chain': 'off',
-    '@typescript-eslint/prefer-string-starts-ends-with': 'off',
-    '@typescript-eslint/require-await': 'off',
-    '@typescript-eslint/restrict-plus-operands': 'off',
-    '@typescript-eslint/restrict-template-expressions': 'off',
-    '@typescript-eslint/sort-type-constituents': 'off',
-    '@typescript-eslint/unbound-method': 'off',
-    '@typescript-eslint/no-explicit-any': 'off',
+		// Todo: do we want these?
+		'@typescript-eslint/array-type': 'off',
+		'@typescript-eslint/ban-ts-comment': 'off',
+		'@typescript-eslint/class-literal-property-style': 'off',
+		'@typescript-eslint/consistent-indexed-object-style': 'off',
+		'@typescript-eslint/consistent-type-definitions': 'off',
+		'@typescript-eslint/dot-notation': 'off',
+		'@typescript-eslint/no-base-to-string': 'off',
+		'@typescript-eslint/no-empty-function': 'off',
+		'@typescript-eslint/no-floating-promises': 'off',
+		'@typescript-eslint/no-misused-promises': 'off',
+		'@typescript-eslint/no-redundant-type-constituents': 'off',
+		'@typescript-eslint/no-this-alias': 'off',
+		'@typescript-eslint/no-unsafe-argument': 'off',
+		'@typescript-eslint/no-unsafe-assignment': 'off',
+		'@typescript-eslint/no-unsafe-call': 'off',
+		'@typescript-eslint/no-unsafe-member-access': 'off',
+		'@typescript-eslint/no-unsafe-return': 'off',
+		'@typescript-eslint/prefer-nullish-coalescing': 'off',
+		'@typescript-eslint/prefer-optional-chain': 'off',
+		'@typescript-eslint/prefer-string-starts-ends-with': 'off',
+		'@typescript-eslint/require-await': 'off',
+		'@typescript-eslint/restrict-plus-operands': 'off',
+		'@typescript-eslint/restrict-template-expressions': 'off',
+		'@typescript-eslint/sort-type-constituents': 'off',
+		'@typescript-eslint/unbound-method': 'off',
+		'@typescript-eslint/no-explicit-any': 'off',
 
-    // These rules enabled by the preset configs don't work well for us
-    '@typescript-eslint/await-thenable': 'off',
-    'prefer-const': 'off',
-  },
-  overrides: [
-    {
-      // Ensure Node builtins aren't included in Astro's server runtime
-      files: ['packages/astro/src/runtime/**/*.ts'],
-      rules: {
-        'no-restricted-imports': [
-          'error',
-          {
-            paths: [...builtinModules],
-            patterns: ['node:*'],
-          },
-        ],
-      },
-    },
-    {
-      files: ['packages/**/test/*.js', 'packages/**/*.js'],
-      env: {
-        mocha: true,
-      },
-      globals: {
-        globalThis: false, // false means read-only
-      },
-      rules: {
-        'no-console': 'off',
-      },
-    },
-    {
-      files: ['packages/integrations/**/*.ts'],
-      rules: {
-        'no-console': ['error', { allow: ['warn', 'error', 'info', 'debug'] }],
-      },
-    },
-    {
-      files: ['benchmark/**/*.js'],
-      rules: {
-        '@typescript-eslint/no-unused-vars': 'off',
-        'no-console': 'off',
-      },
-    },
-  ],
+		// These rules enabled by the preset configs don't work well for us
+		'@typescript-eslint/await-thenable': 'off',
+		'prefer-const': 'off',
+	},
+	overrides: [
+		{
+			// Ensure Node builtins aren't included in Astro's server runtime
+			files: ['packages/astro/src/runtime/**/*.ts'],
+			rules: {
+				'no-restricted-imports': [
+					'error',
+					{
+						paths: [...builtinModules],
+						patterns: ['node:*'],
+					},
+				],
+			},
+		},
+		{
+			files: ['packages/**/test/*.js', 'packages/**/*.js'],
+			env: {
+				mocha: true,
+			},
+			globals: {
+				globalThis: false, // false means read-only
+			},
+			rules: {
+				'no-console': 'off',
+			},
+		},
+		{
+			files: ['packages/integrations/**/*.ts'],
+			rules: {
+				'no-console': ['error', { allow: ['warn', 'error', 'info', 'debug'] }],
+			},
+		},
+		{
+			files: ['benchmark/**/*.js'],
+			rules: {
+				'@typescript-eslint/no-unused-vars': 'off',
+				'no-console': 'off',
+			},
+		},
+	],
 };

.git-blame-ignore-revs

@@ -4,3 +4,5 @@
 1335797903a57716e9a02b0ffd8ca636b3883c62
 # Manually format .astro files in example projects (#3862)
 59e8c71786fd1c154904b3fefa7d26d88f4d92d2
+# New formatting using Biome
+07613b96bbe7a74179895c8cbe5f364133edd9ee

.github/scripts/bundle-size.mjs

@@ -1,18 +1,18 @@
-import { build } from 'esbuild';
 import { existsSync } from 'node:fs';
+import { build } from 'esbuild';
 
 const CLIENT_RUNTIME_PATH = 'packages/astro/src/runtime/client/';
 
 function formatBytes(bytes, decimals = 2) {
-    if (bytes === 0) return '0 B';
+	if (bytes === 0) return '0 B';
 
-    const k = 1024;
-    const dm = decimals < 0 ? 0 : decimals;
-    const sizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
+	const k = 1024;
+	const dm = decimals < 0 ? 0 : decimals;
+	const sizes = ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
 
-    const i = Math.floor(Math.log(bytes) / Math.log(k));
+	const i = Math.floor(Math.log(bytes) / Math.log(k));
 
-    return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
+	return parseFloat((bytes / Math.pow(k, i)).toFixed(dm)) + ' ' + sizes[i];
 }
 
 export default async function checkBundleSize({ github, context }) {
@@ -24,7 +24,7 @@ export default async function checkBundleSize({ github, context }) {
 		pull_number: PR_NUM,
 	});
 	const clientRuntimeFiles = files.filter((file) => {
-		return file.filename.startsWith(CLIENT_RUNTIME_PATH) && file.status !== 'removed'
+		return file.filename.startsWith(CLIENT_RUNTIME_PATH) && file.status !== 'removed';
 	});
 	if (clientRuntimeFiles.length === 0) return;
 
@@ -35,17 +35,26 @@ export default async function checkBundleSize({ github, context }) {
 	const output = await bundle(clientRuntimeFiles);
 
 	for (let [filename, { oldSize, newSize, sourceFile }] of Object.entries(output)) {
-		filename = ['idle', 'load', 'media', 'only', 'visible'].includes(filename) ? `client:${filename}` : filename;
-		const prefix = (newSize - oldSize) === 0 ? '' : (newSize - oldSize) > 0 ? '+ ' : '- ';
+		filename = ['idle', 'load', 'media', 'only', 'visible'].includes(filename)
+			? `client:${filename}`
+			: filename;
+		const prefix = newSize - oldSize === 0 ? '' : newSize - oldSize > 0 ? '+ ' : '- ';
 		const change = `${prefix}${formatBytes(newSize - oldSize)}`;
-		table.push(`| [\`${filename}\`](https://github.com/${context.repo.owner}/${context.repo.repo}/tree/${context.payload.pull_request.head.ref}/${sourceFile}) | ${formatBytes(oldSize)} | ${formatBytes(newSize)} | ${change} |`);
+		table.push(
+			`| [\`${filename}\`](https://github.com/${context.repo.owner}/${context.repo.repo}/tree/${
+				context.payload.pull_request.head.ref
+			}/${sourceFile}) | ${formatBytes(oldSize)} | ${formatBytes(newSize)} | ${change} |`
+		);
 	}
 
 	const { data: comments } = await github.rest.issues.listComments({
 		...context.repo,
-		issue_number: PR_NUM
-	})
-	const comment = comments.find(comment => comment.user.login === 'github-actions[bot]' && comment.body.includes('Bundle Size Check'));
+		issue_number: PR_NUM,
+	});
+	const comment = comments.find(
+		(comment) =>
+			comment.user.login === 'github-actions[bot]' && comment.body.includes('Bundle Size Check')
+	);
 	const method = comment ? 'updateComment' : 'createComment';
 	const payload = comment ? { comment_id: comment.id } : { issue_number: PR_NUM };
 	await github.rest.issues[method]({
@@ -60,26 +69,35 @@ ${table.join('\n')}`,
 }
 
 async function bundle(files) {
-
 	const { metafile } = await build({
-		entryPoints: [...files.map(({ filename }) => filename), ...files.map(({ filename }) => `main/${filename}`).filter(f => existsSync(f))],
+		entryPoints: [
+			...files.map(({ filename }) => filename),
+			...files.map(({ filename }) => `main/${filename}`).filter((f) => existsSync(f)),
+		],
 		bundle: true,
 		minify: true,
 		sourcemap: false,
 		target: ['es2018'],
 		outdir: 'out',
 		metafile: true,
-	})
+	});
 
 	return Object.entries(metafile.outputs).reduce((acc, [filename, info]) => {
 		filename = filename.slice('out/'.length);
 		if (filename.startsWith('main/')) {
 			filename = filename.slice('main/'.length).replace(CLIENT_RUNTIME_PATH, '').replace('.js', '');
 			const oldSize = info.bytes;
-			return Object.assign(acc, { [filename]: Object.assign(acc[filename] ?? { oldSize: 0, newSize: 0 }, { oldSize }) });
+			return Object.assign(acc, {
+				[filename]: Object.assign(acc[filename] ?? { oldSize: 0, newSize: 0 }, { oldSize }),
+			});
 		}
 		filename = filename.replace(CLIENT_RUNTIME_PATH, '').replace('.js', '');
 		const newSize = info.bytes;
-		return Object.assign(acc, { [filename]: Object.assign(acc[filename] ?? { oldSize: 0, newSize: 0 }, { newSize, sourceFile: Object.keys(info.inputs).find(src => src.endsWith('.ts')) }) });
+		return Object.assign(acc, {
+			[filename]: Object.assign(acc[filename] ?? { oldSize: 0, newSize: 0 }, {
+				newSize,
+				sourceFile: Object.keys(info.inputs).find((src) => src.endsWith('.ts')),
+			}),
+		});
 	}, {});
 }

.prettierignore

@@ -16,3 +16,9 @@ benchmark/results/
 
 # Files
 pnpm-lock.yaml
+*.js
+*.ts
+*.mjs
+*.cjs
+*.json
+*.jsonc

benchmark/bench/memory.js

@@ -1,7 +1,7 @@
-import { execaCommand } from 'execa';
-import { markdownTable } from 'markdown-table';
 import fs from 'node:fs/promises';
 import { fileURLToPath } from 'node:url';
+import { execaCommand } from 'execa';
+import { markdownTable } from 'markdown-table';
 import { astroBin } from './_util.js';
 
 /** @typedef {Record<string, import('../../packages/astro/src/core/config/timer').Stat>} AstroTimerStat */

benchmark/bench/render.js

@@ -1,12 +1,12 @@
-import { execaCommand } from 'execa';
-import { markdownTable } from 'markdown-table';
 import fs from 'node:fs/promises';
 import http from 'node:http';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
+import { execaCommand } from 'execa';
+import { markdownTable } from 'markdown-table';
 import { waitUntilBusy } from 'port-authority';
-import { calculateStat, astroBin } from './_util.js';
 import { renderFiles } from '../make-project/render-default.js';
+import { astroBin, calculateStat } from './_util.js';
 
 const port = 4322;
 

benchmark/bench/server-stress.js

@@ -1,8 +1,8 @@
+import fs from 'node:fs/promises';
+import { fileURLToPath } from 'node:url';
 import autocannon from 'autocannon';
 import { execaCommand } from 'execa';
 import { markdownTable } from 'markdown-table';
-import fs from 'node:fs/promises';
-import { fileURLToPath } from 'node:url';
 import { waitUntilBusy } from 'port-authority';
 import pb from 'pretty-bytes';
 import { astroBin } from './_util.js';

benchmark/index.js

@@ -1,7 +1,7 @@
-import mri from 'mri';
 import fs from 'node:fs/promises';
 import path from 'node:path';
 import { pathToFileURL } from 'node:url';
+import mri from 'mri';
 
 const args = mri(process.argv.slice(2));
 

benchmark/packages/timer/src/preview.ts

@@ -1,5 +1,5 @@
-import type { CreatePreviewServer } from 'astro';
 import { createServer } from 'node:http';
+import type { CreatePreviewServer } from 'astro';
 import enableDestroy from 'server-destroy';
 
 const preview: CreatePreviewServer = async function ({ serverEntrypoint, host, port }) {

benchmark/packages/timer/src/server.ts

@@ -1,6 +1,6 @@
+import type { IncomingMessage, ServerResponse } from 'node:http';
 import type { SSRManifest } from 'astro';
 import { NodeApp, applyPolyfills } from 'astro/app/node';
-import type { IncomingMessage, ServerResponse } from 'node:http';
 
 applyPolyfills();