fix: no asset plugin w/ img is imported with query #8353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bbc8c89 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
added 2 commits
September 1, 2023 16:03
github-actions
bot
added
pkg: vue
Princesseuh
reviewed
Sep 1, 2023
added 2 commits
September 1, 2023 20:14
Princesseuh
approved these changes
Sep 1, 2023
|
Is something missing from this PR? thank youu |
Nothing wrong, I'll check it out tomorrow. Sorry for the delay! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8333
Changes
When importing an image with query parameters, astro now skips the assets compilation and lets the other vite plugins do their thing.
Testing
Added automated tests.
If you want to test it manually, check out the mini test repo here.
Docs
The previous behavior was unexpected.