Fixes an issue where view transitions to the 404-page did not work #9642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 931b7bd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
lilnasy
approved these changes
Jan 8, 2024
lilnasy
reviewed
Jan 8, 2024
Co-authored-by: Florian Lefebvre <[email protected]>
github-actions
bot
removed
the
pr: docs
Co-authored-by: Arsh <[email protected]>
Merged
bluwy
reviewed
Jan 8, 2024
Comment on lines
-373
to
+376
| response = new Response(response.body, { ...response, status }); | ||
| response = new Response(response.body, { | ||
| status: status, | ||
| headers: response.headers | ||
| }); |
There was a problem hiding this comment.
Can confirm that ...response seems to do nothing here 👍 We could also copy over statusText, but not a big deal I think
There was a problem hiding this comment.
That was it originally. I advised against it.
There was a problem hiding this comment.
Ah, looks like you're already one step ahead 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the cloning of a Response in route.ts to retain the original headers.
With the headers the content type of the 404 page was lost.
The view transition loader expected text/html and did a full reload due to the missing header.
Closes #9629
Testing
new e2e test to confirm that we can transition to 404 / undefined pages without reloads
Docs
n.a. / bug fix