Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental from content collections! #2354

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

bholmesdev
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

  • It's baseline time.

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 441e2de
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63c04851bc9d4b000aefead0
😎 Deploy Preview https://deploy-preview-2354--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! This should be ready to merge when the next beta goes out 🥳

One note: I’d suggest changing the <Since /> component on line 16 to v="2.0.0" now that we’re removing the note about experimental config as it won’t really be available in any obvious way in 1.7.0.

Maybe worth double checking we’re not saying 1.7.0 anywhere else for this? Ah, yup a few other places: API & CLI Reference pages.

Otherwise LGTM!

@bholmesdev bholmesdev force-pushed the feat/remove-content-collections-experimental-flag branch from 9263400 to b21283f Compare January 12, 2023 17:48
@bholmesdev bholmesdev merged commit b1b1f0e into main Jan 12, 2023
@bholmesdev bholmesdev deleted the feat/remove-content-collections-experimental-flag branch January 12, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants