-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): document new option #6265
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for making sure this is documented!
I have added some potential alternative phrasing, should you desire to choose one.
I hope this helps!
Tried adding a tiny bit to the section directly above to help with the issue where people are forgetting to make an index page when
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ematipico - See what you think about these changes. Since I knew you were also adding an error message about a missing index.astro
file, I figured we could help the existing documentation here too, at the same time.
Please check the additions below and edit for correctness as necessary. e.g. I invented a reason why someone might configure this as false
, to give more context. I think it's ok to expand this, but I'd like to make sure this is accurate/gives the right nuance!
Thank you, Sarah; I like very much the new phrasing! |
Note to self: ADD A LINK TO THE CONFIG REFERENCE ITEM But otherwise, happy with the wording! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link will fail until #6437 is merged.
Co-authored-by: Sarah Rainsberger <[email protected]>
Description (required)
Closes PLT-1431
This PR adds documentation for the upcoming new option. I added a small chapter, I don't know if I need to repeat the examples. Let me know what you think.
Related issues & labels (optional)
For Astro version:
4.2
. See astro PR #9638.