Splash page marketing update #1400
Conversation
superbryntendo
changed the title
… the splash/landing page used for marketing. cleanup and warning resolution.
…om the splash page...
|
@mxstbr I'll need your help with wrapping this up. I needed to move the splash page inside the router to be able to link to internal pages from both buttons AND the search component (so tags were out of the question...) Now, the problem is that I can't force the nav bar not to render in the splash page. Brian and I both tried some solutions to this problem and came up short. Would love your help on this so we can push it out the door finally! |
|
On it |
|
I reworked the way the |
|
BUG: Clicking "Sign in" on the home redirects to |
|
The Navbar hiding should be done, can you double check all edge cases? I think it's correct though. |
|
Fixed login page in 2a2a76b! |
…rks 50% of the time-ish?)
|
This is ready to go IMO! Let's ship it @brianlovin! |
|
Logging out doesn't work for me - flashes the splash page then immediately re-renders the Dashboard. I know you were having issues with this too, @uberbryn - maybe @mxstbr can help us pinpoint why logging out isn't working? |
|
Yep, this is a symptome of our logout process not working and the way we do the homepage fallback continuously now rather than determining it at first render. (like we did before) Going to dig into this. |
|
Any luck? I tried clearing cookies and creating an action to clear state. Couldn't get the cookie to clear though. |
|
Neither, got my new laptop today so I only tried for like half an hour though. Was just about to dig in again, I think it's due to a race condition in requests, will try and figure it out! |
|
The only thing I'm missing from the homepage is a list of some of the biggest communities. The search is nice and all but it's kinda hard to know what to search for when you barely even know what Spectrum's about. Would be nice to show some of the top communities below that? Or maybe some small text saying "Try searching for 'React', 'SpecFM', 'JavaScript'?" or something like that? |
|
Added signed out fallbacks for all major internal-only pages. Now going to dig into the signing out thing since that's totally my bug. |
Falls back to Login for most pages and Splash for the home ones.
|
I think I just fixed signing out and in!! (it was a single option change in our session middleware...) Deploy incoming: https://spectrum-vkpdsuwkdr.now.sh/ Please thoroughly test signing in and out of this before shipping! |
|
The logout stuff doesn't work yet if you log in again, f%%%%%%%, getting closer. |
|
Fuck logging out let's just remove that button and be done with it ugh |
|
cool. i have to run, but I'm good with that for now. Maybe just comment out the whole dropdown for users for the time being? |
|
Let's just comment out the logout button. Easy access to settings is still good. |
|
Done! |
|
Great. Is this good to ship then? |
|
I guess? Give it another full test but I think we're good to go. |
No description provided.