Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract global typings #4243

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

noomorph
Copy link
Collaborator

Description

In this pull request, I have split index.d.ts into detox.d.ts and globals.d.ts.

This will allow us to make a breaking change about types in Detox 21, e.g.:

   "compilerOptions": {
    ...
-     "types": ["node", "jest", "detox"]
+     "types": ["node", "jest", "detox/globals"]
   },

@noomorph noomorph requested a review from d4vidi as a code owner October 26, 2023 09:35
@noomorph noomorph merged commit fa5dcf8 into master Oct 26, 2023
3 checks passed
@noomorph noomorph deleted the refactor/split-definitions branch October 26, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant