Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interface] Allow array in HintProps.message #3133

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Conversation

andykog
Copy link
Member

@andykog andykog commented Jun 12, 2024

Description

Allow passing (string | ReactElement)[] in HintProps.message. This is handy when we want to pass a string with formatting (array of strings / elements)

Changelog

Improved HintProps typing

Additional info

N/A

andykog added 2 commits June 12, 2024 13:08
## Description
Allow passing `(string | ReactElement)[]` in HintProps.message. This is handy when we want to pass a string with formatting (array of strings / <Text /> elements) 

## Changelog
Improved HintProps typing

## Additional info
N/A
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment

src/components/hint/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@adids1221 adids1221 merged commit ee3c4de into master Jun 19, 2024
1 check passed
@adids1221 adids1221 deleted the andykog-patch-2 branch June 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants