Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix types for TextField validate props #3160

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix types for TextField validate props #3160

merged 3 commits into from
Sep 4, 2024

Conversation

ipanasenko
Copy link
Contributor

Description

Type of TextField's validate prop is too generic. We know it will be invoked with a string and needs to return a boolean value

Changelog

  • TextField - update type for validate prop

@ipanasenko ipanasenko marked this pull request as ready for review July 2, 2024 13:31
@Inbal-Tish
Copy link
Collaborator

#rebuild

@ethanshar ethanshar enabled auto-merge (squash) September 4, 2024 05:07
@ethanshar
Copy link
Collaborator

@ipanasenko Fixed some TS error should be ok now

@ethanshar ethanshar self-assigned this Sep 4, 2024
@ethanshar ethanshar merged commit abeac15 into master Sep 4, 2024
1 check passed
@ethanshar ethanshar deleted the ipanasenko-patch-1 branch September 4, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipanasenko @Inbal-Tish @ethanshar