Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker - fix usePickerLabel #3162

Merged
merged 7 commits into from
Jul 7, 2024
Merged

Picker - fix usePickerLabel #3162

merged 7 commits into from
Jul 7, 2024

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Jul 3, 2024

Description

Picker - usePickerLabel - fix picker label is empty if the 'value' prop is a string and no 'items' passed.

usacase: <Picker value={'Picker Value'}/>

Changelog

⚠️ Picker - usePickerLabel - fix picker label is empty if the 'value' prop is a string and no 'items' passed.

Additional info

@Inbal-Tish Inbal-Tish requested review from adids1221 and removed request for adids1221 July 3, 2024 12:01
@Inbal-Tish Inbal-Tish requested a review from adids1221 July 3, 2024 12:36
@Inbal-Tish Inbal-Tish changed the title Fix/picker get picker label Picker - fix get picker label Jul 3, 2024
@Inbal-Tish Inbal-Tish changed the title Picker - fix get picker label Picker - fix usePickerLabel Jul 3, 2024
Copy link
Contributor

@adids1221 adids1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I think we should add test coverage for this case.

@Inbal-Tish Inbal-Tish added the Important for Next Release PR that must be included in the release version label Jul 7, 2024
@Inbal-Tish Inbal-Tish requested a review from adids1221 July 7, 2024 09:19
@adids1221 adids1221 merged commit 03ca7ff into master Jul 7, 2024
1 check passed
@adids1221 adids1221 deleted the fix/Picker_getPickerLabel branch July 7, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants