Emojis type export #3163
Merged
Emojis type export #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exported emojis type
M-i-k-e-l
reviewed
Jul 4, 2024
| @@ -1,5 +1,6 @@ | |||
| /* ===== General Stuff ===== */ | |||
| export {default as Assets} from './assets'; | |||
| export type {emojis as EmojisAssetsType} from './assets/emojis'; | |||
There was a problem hiding this comment.
I'm assuming you'll use this in private, how?
There was a problem hiding this comment.
We have the casting on the assets object in the private repo. When i'll have this type I can add it to the cast and it will be added to the type.
M-i-k-e-l
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export emojis type so it can be added to the assets typings.
Changelog
Export assets emojis type
Additional info
MADS-4306